Incus: make prompts visible for end-user - #73
Merged
Merged
Conversation
incus exec has no pty, so bash printed no read -p prompt: the question was invisible and its EOF aborted the install under catch_errors. A read shim in the container prints the prompt itself and treats EOF as the default, and prompt_confirm no longer needs /dev/tty to ask.
The arm64 confirmation and the apt mirror fallback tested for a tty or opened /dev/tty directly, so under Incus the first aborted every unverified arm64 install with exit 106 and the second could never be offered.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/incus-prompts-visible \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/ct/debian.sh)"Swap This PR touches Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/incus-prompts-visible/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/ProxmoxVED/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/incus-prompts-visibleNote that Useful flags while testing
|
CrazyWolf13
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
example docker, no read -rp is displayed, incus exec has no pty, so bash printed no read -p prompt: the question was invisible and its EOF aborted the install under catch_errors. A read shim in
the container prints the prompt itself and treats EOF as the default, and prompt_confirm no longer needs /dev/tty to ask.
2nd.)
The arm64 confirmation and the apt mirror fallback tested for a tty or opened /dev/tty directly, so under Incus the first aborted every unverified arm64 install with exit 106 and the second could never be offered.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.